fix: install cargo-about with --features=cli#600
Merged
Conversation
With release 0.9 of cargo-about it is now required to specify the cli feature for it to be properly installed as an executable binary. If said feature is not added, installation fails with the message: ``` warning: none of the package's binaries are available for install using the selected features bin "cargo-about" requires the features: `cli` Consider enabling some of the needed features by passing, e.g., `--features="cli"` ``` There is also a bit of cleaning up, namely we add `THIRD_PARTY_LICENSES.html` to the list of ignored files and make sure that `make clean` removes it.
This reverts commit e9f20b6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With release 0.9 of cargo-about it is now required to specify the cli feature for it to be properly installed as an executable binary. If said feature is not added, installation fails with the message:
There is also a bit of cleaning up, namely we add
THIRD_PARTY_LICENSES.htmlto the list of ignored files and make sure thatmake cleanremoves it. We also changed from installingcargo-aboutas part of themake licensestarget, checking if the binary is installed and letting the user know how to install it if it is not.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Manually tested on my machine.
CI run